linux-kernel - Re: [PATCH 1/1] gpio: Provide the STMPE GPIO driver with its own IRQ Domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Dec 2012 09:14:17 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arnd@...db.de, linus.walleij@...ricsson.com,
	viresh.kumar@...aro.org, Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH 1/1] gpio: Provide the STMPE GPIO driver with its own IRQ
 Domain

On Sat, 01 Dec 2012, Linus Walleij wrote:

> On Fri, Nov 23, 2012 at 4:19 PM, Lee Jones <lee.jones@...aro.org> wrote:
> 
> > The STMPE GPIO driver can be used as an IRQ controller by some
> > related devices. Here we provide it with its very own IRQ Domain
> > so that IRQs can be issued dynamically. This will stand the
> > driver in good stead when it is enabled for Device Tree, as this
> > it a prerequisite.
> >
> > Cc: Grant Likely <grant.likely@...retlab.ca>
> > Reviewed-by: Viresh Kumar <viresh.kumar@...aro.org>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> The patch looks bogus since there is no code exercising the added
> irqdomain code in this patch, it's basically a no-op in the irq
> path, which is wrong for an irqdomain.
> 
> It is lacking a irq_create_mapping() in stmpe_gpio_to_irq(),
> removal of the irq_base member and usage of
> irq_find_mapping() in stmpe_gpio_irq().
> 
> Only then will the irqdomain actually be used for what it's
> intended for.
> 
> So I get the impression that this is one of these "let's
> just throw a dummy irqdomain in there so we can use
> it with devicetree" kind of things...

It's not meant to be bogus, as it will be used.

Albeit, we are not uses of the GPIO functionality AFAICT.

I'll look at your comments in a bit and fixup.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/