linux-kernel - Re: [PATCH v3] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Dec 2012 14:58:22 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	"'LKML'" <linux-kernel@...r.kernel.org>,
	"'Marko Katic'" <dromede@...il.com>,
	"'Grant Likely'" <grant.likely@...retlab.ca>,
	"'Florian Tobias Schandinat'" <FlorianSchandinat@....de>,
	"'Richard Purdie'" <rpurdie@...ys.net>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] backlight: corgi_lcd: Use gpio_set_value_cansleep()
 to avoid WARN_ON

On Tue, 04 Dec 2012 14:28:15 +0900
Jingoo Han <jg1.han@...sung.com> wrote:

> From: Marko Katic <dromede@...il.com>
> 
> Changing backlight intensity on an Akita (Sharp Zaurus C-1000)
> triggers WARN_ON message:

Well, I queued it up.

> ...
>
> --- a/drivers/video/backlight/corgi_lcd.c
> +++ b/drivers/video/backlight/corgi_lcd.c
> @@ -408,11 +408,20 @@ static int corgi_bl_set_intensity(struct corgi_lcd *lcd, int intensity)
>  	/* Bit 5 via GPIO_BACKLIGHT_CONT */
>  	cont = !!(intensity & 0x20) ^ lcd->gpio_backlight_cont_inverted;
>  
> -	if (gpio_is_valid(lcd->gpio_backlight_cont))
> -		gpio_set_value(lcd->gpio_backlight_cont, cont);
> +	if (gpio_is_valid(lcd->gpio_backlight_cont)) {
> +		if (gpio_cansleep(lcd->gpio_backlight_cont))
> +			gpio_set_value_cansleep(lcd->gpio_backlight_cont, cont);
> +		else
> +			gpio_set_value(lcd->gpio_backlight_cont, cont);
> +	}

But this looks utterly daft.  Grant, these two things are the same - do
we need both of them?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/