linux-kernel - RE: [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 7 Dec 2012 07:12:54 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"Lin, JM" <JM.Lin@...el.com>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"wim@...ana.be" <wim@...ana.be>,
	"plagnioj@...osoft.com" <plagnioj@...osoft.com>
Subject: RE: [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use
 module_platform_driver()

Hi,

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov@...sta.com]
> Sent: 2012年12月7日 2:16
> To: Yang, Wenyou
> Cc: linux-arm-kernel@...ts.infradead.org; linux-watchdog@...r.kernel.org; Lin, JM;
> Ferre, Nicolas; linux-kernel@...r.kernel.org; wim@...ana.be;
> plagnioj@...osoft.com
> Subject: Re: [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use
> module_platform_driver()
> 
> Hello.
> 
> On 12/05/2012 04:34 AM, Wenyou Yang wrote:
> 
> > Using module_platform_driver() replaces module_init() and module_exit()
> > and makes the code simpler.
> 
> > Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> > Cc: wim@...ana.be
> > Cc: linux-watchdog@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > ---
> >  drivers/watchdog/at91sam9_wdt.c |   14 ++------------
> >  1 file changed, 2 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
> > index 5afd3fb..a7c0881 100644
> > --- a/drivers/watchdog/at91sam9_wdt.c
> > +++ b/drivers/watchdog/at91sam9_wdt.c
> > @@ -278,6 +278,7 @@ MODULE_DEVICE_TABLE(of, at91_wdt_dt_ids);
> >  #endif
> >
> >  static struct platform_driver at91wdt_driver = {
> > +	.probe		= at91wdt_probe,
> 
>    You also need to remove '__init' annotation from that function since the
> driver becomes hot-plug aware now.
Thanks, I got it.
> 
> WBR, Sergei

Best Regards,
Wenyou Yang