linux-kernel - Re: [PATCH v6] Cypress PS/2 Trackpad driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Dec 2012 10:13:38 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Kamal Mostafa <kamal@...onical.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, Dudley Du <dudl@...ress.com>,
	David Solda <dso@...ress.com>,
	Troy Abercrombia <ta@...ress.com>,
	Kyle Fazzari <git@...tus.e4ward.com>,
	Mario Limonciello <mario_limonciello@...l.com>,
	Tim Gardner <tim.gardner@...onical.com>,
	Herton Krzesinski <herton.krzesinski@...onical.com>
Subject: Re: [PATCH v6] Cypress PS/2 Trackpad driver

On Mon, Dec 10, 2012 at 06:13:59PM +0100, Henrik Rydberg wrote:
> > > > +config MOUSE_PS2_CYPRESS
> > > > +       bool "Cypress PS/2 mouse protocol extension" if EXPERT
> > > 
> > > Why EXPERT here?
> > > 
> > > > +       default y
> > > 
> > > Should it really be default y here?
> > 
> > 
> > This config entry (with phrases "if EXPERT" and "default y") was simply
> > cloned from similar devices (e.g. SYNAPTICS, ALPS, LIFEBOOK).
> > 
> > If your preference is that CYPRESS should be disabled by default, I'll
> > omit those phrases.  Please advise.
> 
> Dmitry, which default do you prefer here?

Given that psmouse is monolithic and can't be [easily] split into
separate drivers (because they each protocol has to be actively probed),
I believe that allprotocols should be enabled by default. People who
really know what they are doing can reduce the size by compiling parts
of it out.

So copying what other protocols did was right ;)

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/