linux-kernel - Re: [PATCH 4/5] rtl8712: replace min with min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Dec 2012 23:20:42 +0000
From:	Przemo Firszt <przemo@...szt.eu>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
	greg@...ah.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] rtl8712: replace min with min_t

Dnia 2012-12-11, wto o godzinie 01:49 +0300, Dan Carpenter pisze:
[..]
> At the end iwe.u.data.length is going to be a number between 0 and
> 32.  That can easily fit in 16 bits no problem.
> 
> The difference is that, imagine ->network.Ssid.SsidLength is larger
> than u16 like 0x10001.  The cast to u16 changes it to 0x0001 which
> is less than 32 so we would say the minimum is 1 when actually we
> want to say 32 is the min.
> 
Dan,
Thank you! That was the thing that I missed...
New set of patches on the way.
-- 
Kind regards,
Przemo Firszt


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/