linux-kernel - Re: [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping()

Open Source and information security mailing list archives

Date:	Mon, 10 Dec 2012 15:14:17 +0900
From:	김승우 <sw0312.kim@...sung.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	inki.dae@...sung.com, jy0922.shim@...sung.com,
	kyungmin.park@...sung.com, airlied@...ux.ie,
	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, sw0312.kim@...sung.com
Subject: Re: [PATCH -next] drm/exynos/iommu: fix return value check in
 drm_create_iommu_mapping()


On 2012년 12월 07일 21:50, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> In case of error, function arm_iommu_create_mapping() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> index 09db198..3b3d3a6 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> @@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device *drm_dev)
>  	mapping = arm_iommu_create_mapping(&platform_bus_type, priv->da_start,
>  						priv->da_space_size,
>  						priv->da_space_order);
> -	if (!mapping)
> +	if (IS_ERR(mapping))
>  		return -ENOMEM;

One more fix is needed here.
-		return -ENOMEM;
+ 		return PTR_ERR(mapping);

>  
>  	dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Seung-Woo Kim
Samsung Software R&D Center
--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives