linux-kernel - Re: [PATCH RFC 06/13] of: Add empty of_find_device_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Dec 2012 08:59:04 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Sylwester Nawrocki <s.nawrocki@...sung.com>, g.liakhovetski@....de,
	linux-media@...r.kernel.org
Cc:	rob.herring@...xeda.com, thomas.abraham@...aro.org,
	t.figa@...sung.com, sw0312.kim@...sung.com,
	kyungmin.park@...sung.com, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org,
	Sylwester Nawrocki <s.nawrocki@...sung.com>
Subject: Re: [PATCH RFC 06/13] of: Add empty of_find_device_by_node() function definition

On Mon, 10 Dec 2012 20:41:32 +0100, Sylwester Nawrocki <s.nawrocki@...sung.com> wrote:
> This allows users to be compiled without excluding this function
> call with preprocessor directives when CONFIG_OF_DEVICE is disabled.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>

Same question here... Okay, I'll stop replying to these now. :-) When
you repost, for each one of these please tell me why the empty version
is needed. ie. what is the non-OF code block that is simpler if it
doesn't have to worry about CONFIG_OF?

g.

> ---
>  include/linux/of_platform.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
> index b47d204..d8f587f 100644
> --- a/include/linux/of_platform.h
> +++ b/include/linux/of_platform.h
> @@ -96,6 +96,13 @@ extern int of_platform_populate(struct device_node *root,
>  				struct device *parent);
>  #endif /* CONFIG_OF_ADDRESS */
>  
> +#else  /* CONFIG_OF_DEVICE */
> +static inline struct platform_device *of_find_device_by_node(
> +					struct device_node *np)
> +{
> +	return NULL;
> +}
> +
>  #endif /* CONFIG_OF_DEVICE */
>  
>  #if !defined(CONFIG_OF_ADDRESS)
> -- 
> 1.7.9.5
> 

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/