linux-kernel - Re: [PATCH 5/5] spi: fix return value check in hspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Dec 2012 16:36:27 -0800 (PST)
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Cyril Roelandt <tipecaml@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 5/5] spi: fix return value check in hspi_probe().


Hi

> According to its documentation, clk_get() returns a "valid IS_ERR() condition
> containing errno", so we should call IS_ERR() rather than a NULL check.
> 
> Signed-off-by: Cyril Roelandt <tipecaml@...il.com>

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

> ---
>  drivers/spi/spi-sh-hspi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
> index 32f7b55..60cfae5 100644
> --- a/drivers/spi/spi-sh-hspi.c
> +++ b/drivers/spi/spi-sh-hspi.c
> @@ -290,7 +290,7 @@ static int hspi_probe(struct platform_device *pdev)
>  	}
>  
>  	clk = clk_get(NULL, "shyway_clk");
> -	if (!clk) {
> +	if (IS_ERR(clk)) {
>  		dev_err(&pdev->dev, "shyway_clk is required\n");
>  		ret = -EINVAL;
>  		goto error0;
> -- 
> 1.7.10.4
> 
> 
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> spi-devel-general mailing list
> spi-devel-general@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/