linux-kernel - Re: [PATCH 2/3] perf tool: Add support to include non architectural event aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Dec 2012 10:12:03 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 2/3] perf tool: Add support to include non architectural event aliases

Hi Jiri,

On Mon, 17 Dec 2012 14:37:04 +0100, Jiri Olsa wrote:
> Adding support to parse non architectural event aliases
> for given cpu. These aliases will be provided as 'events'
> directory like architectural ones provided by kernel.
>
[snip]
> +
> +$(OUTPUT)$(OUTPUT)arch/$(ARCH)/util/pmu.o: $(OUTPUT)arch/$(ARCH)/util/pmu.c $(OUTPUT)PERF-CFLAGS

Double OUTPUT ? ;)


> +	$(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) \
> +	 '-DPERF_EXEC_PATH="$(perfexecdir_SQ)"' \
> +	 '-DPREFIX="$(prefix_SQ)"' \
> +	 $<
[snip]
> +static int cpu_aliases(struct list_head *head)
> +{
> +	unsigned vendol, model;

s/vendol/vendor/ ?

Thanks,
Namhyung


> +	int ret;
> +
> +	ret = cpu_specs(&vendol, &model);
> +	if (ret) {
> +		pr_info("failed to get cpu aliases");
> +		return 0;
> +	}
> +
> +	switch (vendol) {
> +	/* Intel */
> +	case 0:
> +		return intel_aliases(head, model);
> +	default:
> +		/* unknown vendor.. plenty to cover ;-) */
> +		return 0;
> +	}
> +
> +	return 0;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/