linux-kernel - Re: 32kHz clock removal causes problems omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Dec 2012 15:54:28 +0200
From:	Felipe Balbi <balbi@...com>
To:	Benoit Cousson <b-cousson@...com>
CC:	<balbi@...com>, Peter Ujfalusi <peter.ujfalusi@...com>,
	Luciano Coelho <coelho@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	<svenkatr@...com>, <linux-omap@...r.kernel.org>,
	<linux-mmc@...r.kernel.org>, <cjb@...top.org>, <lrg@...com>,
	<linux-kernel@...r.kernel.org>, Tony Lindgren <tony@...mide.com>,
	<r.sricharan@...com>
Subject: Re: 32kHz clock removal causes problems omap_hsmmc

Hi,

On Wed, Dec 19, 2012 at 02:51:14PM +0100, Benoit Cousson wrote:
> On 12/19/2012 02:01 PM, Felipe Balbi wrote:
> > Hi,
> > 
> > +Sricharan who commited that
> > 
> > On Wed, Dec 19, 2012 at 11:56:20AM +0100, Peter Ujfalusi wrote:
> >> On 12/19/2012 11:45 AM, Luciano Coelho wrote:
> >>>> Well, we still haven't got the foggiest idea what the actual problem is
> >>>> beyond that it's probably related to the 32kHz clock in some way (unless
> >>>> it was one of the other reverts that coincidentally made a difference,
> >>>> but we don't know what they were) so it's unlikely that just randomly
> >>>> implementing clock support is going to fix anything immediately here.
> >>>
> >>> This is exactly what I had to revert (as I mentioned in the other email,
> >>> I had to revert the other patches otherwise compilation would break):
> >>>
> >>> 0e8e5c34 "regulator: twl: Remove references to 32kHz clock from DT bindings"
> >>> e76ab829 "regulator: twl: Remove references to the twl4030 regulator"
> >>> 029dd3ce "regulator: twl: Remove another unused variable warning"
> >>
> >> Yeah. 32k clock is not provided by twl.
> >>
> >> As I said I need to take a look at CCF to see if it already there. If it is
> >> clock driver + mapping + patch for wl12xx should fix the issue you are facing.
> >>
> >>> Let me know if you need more info.
> >>
> >> BTW: have you happened to ubdate u-boot recently? There is a nice easter egg
> >> added there:
> >> f3f98bb ARM: OMAP4/5: Do not configure non essential pads, clocks, dplls.
> >>
> >> Which means that _essential_ clocks and pads are no longer configured.
> > 
> > anything essential you can list ?
> 
> Yeah, that u-boot version is just unusable at all with any mainline
> kernel, since we are still missing pads conf for every drivers.
> 
> Regarding the 32k clock, I noticed as well that the OMAP4460 panda
> u-boot is the only one to enable it at boot time, and thus this is the
> only board that can probe the wilink chip properly as of today.

hah, way to cause regression

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)