lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Dec 2012 04:44:03 -0500 From: Jun Chen <jun.d.chen@...el.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: grant.likely@...retlab.ca, linux-kernel@...r.kernel.org, Bi Chao <chao.bi@...el.com>, spi-devel-general@...ts.sourceforge.net Subject: Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not. On Tue, 2012-12-18 at 15:26 +0000, Mark Brown wrote: > On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote: > > > * @master: Controller to which device is connected > > + * device_was_children_of_master is flag which the device is registed > > + * as the children of the bus > > This isn't a kerneldoc style comment (it needs the @XXX: format). The > name is also extremely long, can't we think of something more concise? > Thank for your suggestion, I will correct this comment and use concise flag. > > - spi->dev.parent = &master->dev; > > + if (device_was_children_of_master == true) > > + spi->dev.parent = &master->dev; > > + else > > + spi->dev.parent = dev; > > Can you provide an example of where this is useful? Your changelog > didn't make it clear and the code doesn't make it obvious either. This spi_alloc_device function will be called in the spi_new_device function to alloc new device as the master. But other way, it is called by the of_register_spi_devices function to register new device as the children of the master. I will update changlog to add it. @@ -434,7 +440,7 @@ struct spi_device *spi_new_device(struct spi_master *master, * suggests syslogged diagnostics are best here (ugh). */ - proxy = spi_alloc_device(master); + proxy = spi_alloc_device(master, false); if (!proxy) return NULL; @@ -827,7 +833,7 @@ static void of_register_spi_devices(struct spi_master *master) for_each_available_child_of_node(master->dev.of_node, nc) { /* Alloc an spi_device */ - spi = spi_alloc_device(master); + spi = spi_alloc_device(master, true); If I have mistake, pls correct me, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists