linux-kernel - Re: [PATCH] serial: tegra: add serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Dec 2012 01:09:02 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Stephen Warren <swarren@...dotorg.org>,
	Laxman Dewangan <ldewangan@...dia.com>
Cc:	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jslaby@...e.cz" <jslaby@...e.cz>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] serial: tegra: add serial driver

On Wed, 19 Dec 2012 09:58:18 -0700, Stephen Warren <swarren@...dotorg.org> wrote:
> On 12/19/2012 07:15 AM, Laxman Dewangan wrote:
> > On Wednesday 19 December 2012 06:31 PM, Grant Likely wrote:
> >> On Mon, 17 Dec 2012 14:31:34 -0700, Stephen
> >> Warren<swarren@...dotorg.org>  wrote:
> >>> On 12/17/2012 10:10 AM, Grant Likely wrote:
> >>>> On Mon, 17 Dec 2012 17:40:49 +0530, Laxman
> >>>> Dewangan<ldewangan@...dia.com>  wrote:
> >>>
> >>> Aren't we still supposed to support platform data so that it can
> >>> override what's in DT in order to fix up bad DTs? Or, has that
> >>> requirement been dropped. If it has, we can drop a bunch of code from a
> >>> variety of Tegra-specific drivers, I expect.
> >> Do you have an actual user for this? If not, then don't borrow trouble.
> >> Just drop it. Things like platform_data can always be added later only
> >> if it is needed.
> > 
> > Currently all our board supports DT. we are not using any driver
> > instantiated by board files.
> > I will remove the platform data for current patch and if it is require
> > then will add later with reasoning.
> > 
> > Hope this will be fine with Stephen also so that  this basic patch can
> > be included into tree soon.
> 
> I'm fine with it; it's just a change in policy that hadn't been
> communicated before.

Not really. For as long as I can remember there has been a strong bias
against unused code in the kernel. That goes for platform_data support
code as much as anything else.

What has been policy is that adding DT support must never break existing
non-DT support as long as non-DT booting is supported by a platform.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/