| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Dec 2012 04:18:01 +0200 From: Ido Yariv <ido@...ery.com> To: Sjur Brændeland <sjur.brandeland@...ricsson.com> Cc: Ohad Ben-Cohen <ohad@...ery.com>, Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, Sjur Brændeland <sjur@...ndeland.net> Subject: Re: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation Hi Sjur, On Fri, Dec 14, 2012 at 05:06:56PM +0100, Sjur Brændeland wrote: > Postpone the registration of virtio devices until all > vritio ring resource has been allocated. > This fixes the following bug: The driver's start callback > is called before all vring notify ids are allocated and > max_notifyid will be increased after starting the remoteproc. It seems that this patch wont solve this issue, since rproc_add_virtio_dev eventually increases max_notifyid, so the same problem will simply occur at a later stage. Also, it seems that the original rproc_add_virtio_dev calls were not removed, so devices would be added twice. If max_notifyid needs to be set before the first virtio device is added, how about counting the number of notification ids in advance before adding the devices, by traversing the resource list twice? Thanks, Ido. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists