linux-kernel - [PATCH] dma: intel_mid: Remove return statements at the end of all void functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 22 Dec 2012 13:53:45 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Dan Williams <djbw@...com>, linux-kernel@...r.kernel.org
Subject: [PATCH] dma: intel_mid: Remove return statements at the end of all
 void functions

Signed-off-by: Axel Lin <axel.lin@...ics.com>
---
 drivers/dma/intel_mid_dma.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c
index bc764af..1a83d1d 100644
--- a/drivers/dma/intel_mid_dma.c
+++ b/drivers/dma/intel_mid_dma.c
@@ -133,7 +133,6 @@ static void dmac1_mask_periphral_intr(struct middma_device *mid)
 		pimr |= mid->pimr_mask;
 		writel(pimr, mid->mask_reg + LNW_PERIPHRAL_MASK);
 	}
-	return;
 }
 
 /**
@@ -154,7 +153,6 @@ static void dmac1_unmask_periphral_intr(struct intel_mid_dma_chan *midc)
 		pimr &= ~mid->pimr_mask;
 		writel(pimr, mid->mask_reg + LNW_PERIPHRAL_MASK);
 	}
-	return;
 }
 
 /**
@@ -172,7 +170,6 @@ static void enable_dma_interrupt(struct intel_mid_dma_chan *midc)
 	/*en ch interrupts*/
 	iowrite32(UNMASK_INTR_REG(midc->ch_id), midc->dma_base + MASK_TFR);
 	iowrite32(UNMASK_INTR_REG(midc->ch_id), midc->dma_base + MASK_ERR);
-	return;
 }
 
 /**
@@ -189,7 +186,6 @@ static void disable_dma_interrupt(struct intel_mid_dma_chan *midc)
 	iowrite32(MASK_INTR_REG(midc->ch_id), midc->dma_base + MASK_BLOCK);
 	iowrite32(MASK_INTR_REG(midc->ch_id), midc->dma_base + MASK_TFR);
 	iowrite32(MASK_INTR_REG(midc->ch_id), midc->dma_base + MASK_ERR);
-	return;
 }
 
 /*****************************************************************************
@@ -341,8 +337,7 @@ static void midc_scan_descriptors(struct middma_device *mid,
 		if (desc->status == DMA_IN_PROGRESS)
 			midc_descriptor_complete(midc, desc);
 	}
-	return;
-	}
+}
 /**
  * midc_lli_fill_sg -		Helper function to convert
  *				SG list to Linked List Items.
@@ -992,7 +987,6 @@ static void dma_tasklet(unsigned long data)
 		spin_unlock_bh(&midc->lock);
 	}
 	pr_debug("MDMA:Exiting takslet...\n");
-	return;
 }
 
 static void dma_tasklet1(unsigned long data)
@@ -1214,7 +1208,6 @@ static void middma_shutdown(struct pci_dev *pdev)
 	if (device->dma_base)
 		iounmap(device->dma_base);
 	free_irq(pdev->irq, device);
-	return;
 }
 
 /**
-- 
1.7.9.5



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/