linux-kernel - Re: [PATCH v7u1 04/31] x86, 64bit, mm: add generic kernel/ident mapping helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Jan 2013 22:19:15 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kiszka <jan.kiszka@....de>,
	Jason Wessel <jason.wessel@...driver.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7u1 04/31] x86, 64bit, mm: add generic kernel/ident
 mapping helper

On Thu, Jan 03, 2013 at 04:48:24PM -0800, Yinghai Lu wrote:
> +int kernel_mapping_init(pgd_t *pgd_page, unsigned long addr, unsigned long end)
> +{
> +	struct x86_mapping_info info = {
> +		.alloc_pgt_page	= alloc_pgt_page,
> +		.pmd_flag	= __PAGE_KERNEL_LARGE,
> +		.kernel_mapping	= true,
> +	};
> +
> +	return kernel_ident_mapping_init(&info, pgd_page, addr, end);

This patch looks good so far except this:
kernel_ident_mapping_init says it initializes ident mapping but
this is wrong and the type of mapping is actually controlled by
info.kernel_mapping.

So this function which gets &info, etc should be called
kernel_mapping_init, AFAICT. And wrt the one wrapping
kernel_ident_mapping_init, I can't seem to find where it is called.
What's up?

Thanks.

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/