linux-kernel - Re: mmotm 2013-01-11-15-47 uploaded (x86 asm-offsets broken)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 12 Jan 2013 13:17:13 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	akpm@...ux-foundation.org, mm-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-fsdevel@...r.kernel.org, linux-next@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: Re: mmotm 2013-01-11-15-47 uploaded (x86 asm-offsets broken)

On Fri, 11 Jan 2013 17:43:06 -0800 Randy Dunlap <rdunlap@...radead.org> wrote:
>
> b0rked.
> 
> Some (randconfig?) causes this set of errors:
> 
>   CC      arch/x86/kernel/asm-offsets.s
> In file included from include/linux/ktime.h:25:0,
>                  from include/linux/timer.h:5,
>                  from include/linux/workqueue.h:8,
>                  from include/linux/srcu.h:34,
>                  from include/linux/notifier.h:15,
>                  from include/linux/memory_hotplug.h:6,
>                  from include/linux/mmzone.h:761,
>                  from include/linux/gfp.h:4,
>                  from include/linux/slab.h:12,
>                  from include/linux/crypto.h:24,
>                  from arch/x86/kernel/asm-offsets.c:8:
> include/linux/jiffies.h: In function '__inline_jiffies_to_msecs':
> include/linux/jiffies.h:306:10: error: 'HZ_TO_MSEC_MUL32' undeclared (first use in this function)
> include/linux/jiffies.h:306:10: note: each undeclared identifier is reported only once for each function it appears in
> include/linux/jiffies.h:306:35: error: 'HZ_TO_MSEC_SHR32' undeclared (first use in this function)
> include/linux/jiffies.h: In function '__inline_jiffies_to_usecs':
> include/linux/jiffies.h:328:10: error: 'HZ_TO_USEC_MUL32' undeclared (first use in this function)
> include/linux/jiffies.h:328:35: error: 'HZ_TO_USEC_SHR32' undeclared (first use in this function)
> include/linux/jiffies.h: In function '__inline_msecs_to_jiffies':
> include/linux/jiffies.h:392:10: error: 'MSEC_TO_HZ_MUL32' undeclared (first use in this function)
> include/linux/jiffies.h:392:33: error: 'MSEC_TO_HZ_ADJ32' undeclared (first use in this function)
> include/linux/jiffies.h:393:6: error: 'MSEC_TO_HZ_SHR32' undeclared (first use in this function)
> include/linux/jiffies.h: In function '__inline_usecs_to_jiffies':
> include/linux/jiffies.h:413:10: error: 'USEC_TO_HZ_MUL32' undeclared (first use in this function)
> include/linux/jiffies.h:413:33: error: 'USEC_TO_HZ_ADJ32' undeclared (first use in this function)
> include/linux/jiffies.h:414:6: error: 'USEC_TO_HZ_SHR32' undeclared (first use in this function)

So, what am I missing? ... how could that have worked - those constants are
generated into kernel/timeconst.h which is only included in kernel/time.c
(from where all this code was moved to jiffies.h).

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped