linux-kernel - [PATCH] gpu: drm/gma500/mdfld_dsi_pkg_sender.c: remove unnecessary null pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2013 01:34:21 +0100
From:	Cong Ding <dinggnu@...il.com>
To:	David Airlie <airlied@...ux.ie>, Dave Airlie <airlied@...hat.com>,
	Alan Cox <alan@...ux.intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:	Cong Ding <dinggnu@...il.com>
Subject: [PATCH] gpu: drm/gma500/mdfld_dsi_pkg_sender.c: remove unnecessary null pointer check

the variable sender is dereferenced in line 536, so it is no reason to
check null again in line 541.

Signed-off-by: Cong Ding <dinggnu@...il.com>
---
 drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
index 489ffd2..823854a 100644
--- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
+++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
@@ -538,7 +538,7 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
 	u32 gen_data_reg;
 	int retry = MDFLD_DSI_READ_MAX_COUNT;
 
-	if (!sender || !data_out || !len_out) {
+	if (!data_out || !len_out) {
 		DRM_ERROR("Invalid parameters\n");
 		return -EINVAL;
 	}
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/