linux-kernel - Re: [dgrp_register_proc] BUG: unable to handle kernel NULL pointer dereference at 0000000000000040

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2013 00:26:05 -0500
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Bill Pemberton <wfp5p@...ginia.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [dgrp_register_proc] BUG: unable to handle kernel NULL pointer
 dereference at 0000000000000040

On Tue, Jan 15, 2013 at 12:10 AM, Fengguang Wu <fengguang.wu@...el.com> wrote:
> 7b6d45c211a401a9bdeebfa96f8a4c811bd3eeaf is the first bad commit
>
> commit 7b6d45c211a401a9bdeebfa96f8a4c811bd3eeaf
> Author: Bill Pemberton <wfp5p@...ginia.edu>
> Date:   Thu Sep 20 16:55:28 2012 -0400
>
>     staging: dgrp: add dgrp to the build
>
>     Kconfig and Makefile changes to add dgrp to the build system.
>
>     Signed-off-by: Bill Pemberton <wfp5p@...ginia.edu>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
> [    7.904899] i2c-core: driver [isl29018] registered
> [    7.906424] i2c-core: driver [tsl2583] registered
> [    7.908289] BUG: unable to handle kernel NULL pointer dereference at 0000000000000040
> [    7.909055] IP: [<ffffffff814f5147>] register_proc_table+0xe0/0x26f
> [    7.909055] PGD 0
> [    7.909055] Oops: 0000 [#1] SMP
> [    7.909055] CPU 0
> [    7.909055] Pid: 1, comm: swapper/0 Not tainted 3.8.0-rc3-00051-gc83dcb9 #16
> [    7.909055] RIP: 0010:[<ffffffff814f5147>]  [<ffffffff814f5147>] register_proc_table+0xe0/0x26f
> [    7.909055] RSP: 0000:ffff88000d0c1e78  EFLAGS: 00010246
> [    7.909055] RAX: 0000000000000003 RBX: 0000000000000000 RCX: 0000000000000003
> [    7.909055] RDX: 0000000000000002 RSI: 0000000000000000 RDI: ffffffff81989648
> [    7.909055] RBP: ffff88000d0c1eb8 R08: 0000000000000000 R09: 0000000000000000
> [    7.909055] R10: ffff88000f4fed68 R11: ffff88000f4fecb8 R12: ffffffff81a9f008
> [    7.909055] R13: 0000000000000000 R14: ffffffff82b3a710 R15: ffffffff81989644
> [    7.909055] FS:  0000000000000000(0000) GS:ffff88000da00000(0000) knlGS:0000000000000000
> [    7.909055] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [    7.909055] CR2: 0000000000000040 CR3: 00000000019a4000 CR4: 00000000000006f0
> [    7.909055] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [    7.927424] tsc: Refined TSC clocksource calibration: 2666.662 MHz
>
> Thanks,
> Fengguang


Hello Fengguang,

Will you try the patch below please...

diff --git a/drivers/staging/dgrp/dgrp_specproc.c
b/drivers/staging/dgrp/dgrp_specproc.c
index c214078..f5845a7 100644
--- a/drivers/staging/dgrp/dgrp_specproc.c
+++ b/drivers/staging/dgrp/dgrp_specproc.c
@@ -231,6 +231,8 @@ static void register_proc_table(struct
dgrp_proc_entry *table,

        if (table == NULL)
                return;
+       if (root == NULL)
+               return;

        for (; table->id; table++) {
                /* Can't do anything without a proc name. */

Applies on current linus's head at 406089d01562f1e2bf9f089fd7637009ebaad589.

I am thinking of the case where you dont have any proc entry.

thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/