linux-kernel - Re: [PATCH] bluetooth: btmrvl_sdio: look for sd8688 firmware in proper location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jan 2013 23:58:13 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Lubomir Rintel <lkundrak@...sk>
Cc:	Bing Zhao <bzhao@...vell.com>, Ben Hutchings <ben@...adent.org.uk>,
	David Woodhouse <dwmw2@...radead.org>,
	Gustavo Padovan <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	libertas-dev@...ts.infradead.org, linux-bluetooth@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bluetooth: btmrvl_sdio: look for sd8688 firmware in
 proper location

Hi Lubumir,

proper commit message with explanation here please.

> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> ---
>  drivers/bluetooth/btmrvl_sdio.c |    8 ++++----
>  drivers/bluetooth/btmrvl_sdio.h |    6 ++++--
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
> index 3f4bfc8..bc27d01 100644
> --- a/drivers/bluetooth/btmrvl_sdio.c
> +++ b/drivers/bluetooth/btmrvl_sdio.c
> @@ -83,8 +83,8 @@ static const struct btmrvl_sdio_card_reg btmrvl_reg_87xx = {
>  };
>  
>  static const struct btmrvl_sdio_device btmrvl_sdio_sd8688 = {
> -	.helper		= "sd8688_helper.bin",
> -	.firmware	= "sd8688.bin",
> +	.helper		= "mrvl/sd8688_helper.bin",
> +	.firmware	= "mrvl/sd8688.bin",
>  	.reg		= &btmrvl_reg_8688,
>  	.sd_blksz_fw_dl	= 64,
>  };
> @@ -1179,7 +1179,7 @@ MODULE_AUTHOR("Marvell International Ltd.");
>  MODULE_DESCRIPTION("Marvell BT-over-SDIO driver ver " VERSION);
>  MODULE_VERSION(VERSION);
>  MODULE_LICENSE("GPL v2");
> -MODULE_FIRMWARE("sd8688_helper.bin");
> -MODULE_FIRMWARE("sd8688.bin");
> +MODULE_FIRMWARE("mrvl/sd8688_helper.bin");
> +MODULE_FIRMWARE("mrvl/sd8688.bin");
>  MODULE_FIRMWARE("mrvl/sd8787_uapsta.bin");
>  MODULE_FIRMWARE("mrvl/sd8797_uapsta.bin");
> diff --git a/drivers/bluetooth/btmrvl_sdio.h b/drivers/bluetooth/btmrvl_sdio.h
> index 43d35a6..4a5a019 100644
> --- a/drivers/bluetooth/btmrvl_sdio.h
> +++ b/drivers/bluetooth/btmrvl_sdio.h
> @@ -84,7 +84,9 @@ struct btmrvl_sdio_card {
>  	struct sdio_func *func;
>  	u32 ioport;
>  	const char *helper;
> +	const char *helper2;
>  	const char *firmware;
> +	const char *firmware2;

And please clear out the patch from left-overs.

>  	const struct btmrvl_sdio_card_reg *reg;
>  	u16 sd_blksz_fw_dl;
>  	u8 rx_unit;
> @@ -92,8 +94,8 @@ struct btmrvl_sdio_card {
>  };
>  
>  struct btmrvl_sdio_device {
> -	const char *helper;
> -	const char *firmware;
> +	const char *helper, *helper2;
> +	const char *firmware, *firmware2;

And here as well.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/