lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Jan 2013 15:53:18 +0100 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: ACPI Devel Maling List <linux-acpi@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, "Kristen C. Accardi" <kristen.c.accardi@...el.com>, Len Brown <lenb@...nel.org> Subject: [RFC][PATCH 1/3] ACPI / PM: Expose reference count values of ACPI power resources From: Rafael J. Wysocki <rafael.j.wysocki@...el.com> Since ACPI power resources are going to be used more extensively on new hardware platforms, it becomes necessary for user space (powertop in particular) to observe some properties of those resources for diagnostics purposes. For this reason, export the reference counts of ACPI power resources to user space by adding a new reference_count attribute to the sysfs directory representing each power resource. The value read from that attribute represents the number of devices using the power resource at the given time. If that value is 0, it meas that the power resource is not used and therefore it has been turned off. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com> --- drivers/acpi/power.c | 26 +++++++++++++++++++++++++- drivers/acpi/scan.c | 3 +++ include/acpi/acpi_bus.h | 1 + 3 files changed, 29 insertions(+), 1 deletion(-) Index: linux-pm/include/acpi/acpi_bus.h =================================================================== --- linux-pm.orig/include/acpi/acpi_bus.h +++ linux-pm/include/acpi/acpi_bus.h @@ -280,6 +280,7 @@ struct acpi_device { struct mutex physical_node_lock; DECLARE_BITMAP(physical_node_id_bitmap, ACPI_MAX_PHYSICAL_NODE); struct list_head power_dependent; + void (*remove)(struct acpi_device *); }; static inline void *acpi_driver_data(struct acpi_device *d) Index: linux-pm/drivers/acpi/scan.c =================================================================== --- linux-pm.orig/drivers/acpi/scan.c +++ linux-pm/drivers/acpi/scan.c @@ -767,6 +767,9 @@ static void acpi_device_unregister(struc acpi_power_add_remove_device(device, false); acpi_device_remove_files(device); + if (device->remove) + device->remove(device); + device_unregister(&device->dev); /* * Drop the reference counts of all power resources the device depends Index: linux-pm/drivers/acpi/power.c =================================================================== --- linux-pm.orig/drivers/acpi/power.c +++ linux-pm/drivers/acpi/power.c @@ -87,6 +87,12 @@ static DEFINE_MUTEX(power_resource_list_ Power Resource Management -------------------------------------------------------------------------- */ +static inline +struct acpi_power_resource *to_power_resource(struct acpi_device *device) +{ + return container_of(device, struct acpi_power_resource, device); +} + static struct acpi_power_resource *acpi_power_get_context(acpi_handle handle) { struct acpi_device *device; @@ -94,7 +100,7 @@ static struct acpi_power_resource *acpi_ if (acpi_bus_get_device(handle, &device)) return NULL; - return container_of(device, struct acpi_power_resource, device); + return to_power_resource(device); } static int acpi_power_resources_list_add(acpi_handle handle, @@ -679,6 +685,21 @@ static void acpi_release_power_resource( kfree(resource); } +static ssize_t acpi_power_refcount_show(struct device *dev, + struct device_attribute *attr, + char *buf) { + struct acpi_power_resource *resource; + + resource = to_power_resource(to_acpi_device(dev)); + return sprintf(buf, "%u\n", resource->ref_count); +} +static DEVICE_ATTR(reference_count, 0444, acpi_power_refcount_show, NULL); + +static void acpi_power_sysfs_remove(struct acpi_device *device) +{ + device_remove_file(&device->dev, &dev_attr_reference_count); +} + int acpi_add_power_resource(acpi_handle handle) { struct acpi_power_resource *resource; @@ -726,6 +747,9 @@ int acpi_add_power_resource(acpi_handle if (result) goto err; + if (!device_create_file(&device->dev, &dev_attr_reference_count)) + device->remove = acpi_power_sysfs_remove; + mutex_lock(&power_resource_list_lock); list_add(&resource->list_node, &acpi_power_resource_list); mutex_unlock(&power_resource_list_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists