linux-kernel - Re: [PATCH v2] HID: add ThingM blink(1) USB RGB LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jan 2013 11:25:29 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	simon@...gewell.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: add ThingM blink(1) USB RGB LED support

On Mon, 21 Jan 2013, Vivien Didelot wrote:

> > > +++ b/Documentation/ABI/testing/sysfs-driver-hid-blink1
> > > @@ -0,0 +1,23 @@
> > > +What:		/sys/class/leds/blink(1)::<serial>/rgb
> > > +Date:		January 2013
> > > +Contact:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> > > +Description:	The ThingM blink(1) is an USB RGB LED. The color
> > > notation is
> > > +		3-byte hexadecimal. Read this attribute to get the last set
> > > +		color. Write the 24-bit hexadecimal color to change the current
> > > +		LED color. The default color is full white (0xFFFFFF).
> > > +		For instance, set the color to green with: echo 00FF00 > rgb
> > > +
> > 
> > Shouldn't the name presented in the sys/class/leds directories change
> > appropriately too?
> 
> The directory name for the device under /sys/class/leds is "blink(1)::<serial>",
> where <serial> is the last 4 digits of the device serial number (the first 4
> digits are always the same: "1A00"). For instance, "blink(1)::1234".
> Let me know if I misunderstood your question.

I believe that Simon's (valid) observation is that the sysfs path should 
reflect the name change, i.e. something along the lines of 
/sys/class/leds/thingm-blink:<serial>   ... ?

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/