linux-kernel - Re: [PATCH v2] usb: phy: moving all PHY API definitions to usb/phy directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Jan 2013 11:32:24 +0200
From:	Roger Quadros <rogerq@...com>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
CC:	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] usb: phy: moving all PHY API definitions to usb/phy
 directory

On 01/23/2013 01:56 AM, Venu Byravarasu wrote:
>> -----Original Message-----
>> From: Roger Quadros [mailto:rogerq@...com]
>> Sent: Tuesday, January 22, 2013 7:51 PM
>> To: Venu Byravarasu
>> Cc: balbi@...com; gregkh@...uxfoundation.org; linux-usb@...r.kernel.org;
>> linux-kernel@...r.kernel.org
>> Subject: Re: [PATCH v2] usb: phy: moving all PHY API definitions to usb/phy
>> directory
>>
>> On 01/22/2013 01:01 PM, Venu Byravarasu wrote:
>>> As drivers/usb/otg/otg.c contains most of the PHY related APIs
>>> which are not OTG specific, moving them to more logical place
>>> under driver/usb/phy.
>>>
>>> Signed-off-by: Venu Byravarasu <vbyravarasu@...dia.com>
>>> ---
>>> delta from v1:
>>> Missed adding newly created file usb_phy.c with previous patch.
>>> hence sending v2, after adding that.
>>>
>>>  drivers/usb/otg/otg.c                    |  184 ------------------------------
>>>  drivers/usb/phy/Makefile                 |    1 +
>>>  drivers/usb/{otg/otg.c => phy/usb_phy.c} |   45 +-------
>>>  3 files changed, 6 insertions(+), 224 deletions(-)
>>>  copy drivers/usb/{otg/otg.c => phy/usb_phy.c} (82%)
>>
>> what about updating
>> drivers/usb/otg/Makefile and Kconfig?
>>
>> i.e. remove CONFIG_USB_OTG_UTILS and otg.o there?
> 
> Thanks for your comments.
> Those files may still be needed, as we're not removing otg.c,
> due to remaining only otg function i.e. otg_state_string().
> 

Oh yes, in that case it is fine.

--
cheers,
-roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/