linux-kernel - Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jan 2013 16:18:34 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	fangxiaozhi 00110321 <fangxiaozhi@...wei.com>
CC:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	zihan@...wei.com, Lin.Lei@...wei.com, greg@...ah.com,
	neil.yi@...wei.com, wangyuhua@...wei.com, huqiao36@...wei.com,
	balbi@...com, mdharm-usb@...-eyed-alien.net,
	sebastian@...akpoint.cc
Subject: Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match
 rules

Hello.

On 25-01-2013 6:44, fangxiaozhi 00110321 wrote:

> From: fangxiaozhi <huananhu@...wei.com>

> 1. Define a new macro for USB storage match rules:
>      matching with Vendor ID and interface descriptors.

> Signed-off-by: fangxiaozhi <huananhu@...wei.com>
> --------------------------------------------------------------------
>
>   diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usb.c linux-3.8-rc4/drivers/usb/storage/usb.c
> --- linux-3.8-rc4_orig/drivers/usb/storage/usb.c 2013-01-22 14:12:42.595238727 +0800
> +++ linux-3.8-rc4/drivers/usb/storage/usb.c 2013-01-22 14:16:01.398250305 +0800
> @@ -120,6 +120,17 @@ MODULE_PARM_DESC(quirks, "supplemental l
>    .useTransport = use_transport, \
>   }
>
> +#define UNUSUAL_VENDOR_INTF(idVendor, cl, sc, pr, \
> +         vendor_name, product_name, use_protocol, use_transport, \
> +         init_function, Flags) \
> +{ \
> + .vendorName = vendor_name, \
> + .productName = product_name, \
> + .useProtocol = use_protocol, \
> + .useTransport = use_transport, \
> + .initFunction = init_function, \
> +}

   Shouldn't the field initilaizers be indented with tab, not space?

> diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usual-tables.c linux-3.8-rc4/drivers/usb/storage/usual-tables.c
> --- linux-3.8-rc4_orig/drivers/usb/storage/usual-tables.c 2013-01-22 14:12:42.594238726 +0800
> +++ linux-3.8-rc4/drivers/usb/storage/usual-tables.c 2013-01-22 14:16:01.426250199 +0800
> @@ -41,6 +41,19 @@
>   #define USUAL_DEV(useProto, useTrans) \
>   { USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, useProto, useTrans) }
>
> +/* Define the device is matched with Vendor ID and interface descriptors */
> +#define UNUSUAL_VENDOR_INTF(id_vendor, cl, sc, pr, \
> +                 vendorName, productName, useProtocol, useTransport, \
> +                 initFunction, flags) \
> +{ \
> + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO \
> +                         | USB_DEVICE_ID_MATCH_VENDOR, \
> + .idVendor    = (id_vendor), \
> + .bInterfaceClass = (cl), \
> + .bInterfaceSubClass = (sc), \
> + .bInterfaceProtocol = (pr), \
> + .driver_info = (flags) }

    Same question. And trailing '}' should be on a separate line.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/