[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 27 Jan 2013 01:42:00 +0100
From: Samuel Ortiz <sameo@...ux.intel.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Kevin Hilman <khilman@...prootsystems.com>,
"Kristo, Tero" <t-kristo@...com>
Subject: Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return
code
Hi Arnd,
On Fri, Jan 25, 2013 at 10:44:08PM +0000, Arnd Bergmann wrote:
> If the twl4030_write_script function gets called with
> a zero length argument, its return value does not
> get set. We know that all scripts have a nonzero
> length, but returning an error in case they ever
> do is probably appropriate.
>
> Without this patch, building omap2plus_defconfig results in:
>
> drivers/mfd/twl4030-power.c: In function 'load_twl4030_script':
> drivers/mfd/twl4030-power.c:414:5: error: 'err' may be used uninitialized in this function
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@...com>
> Reviewed-by: Amit Kucheria <amit.kucheria@...aro.org>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: Kevin Hilman <khilman@...prootsystems.com>
> Cc: "Kristo, Tero" <t-kristo@...com>
> ---
> drivers/mfd/twl4030-power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to my for-linus branch, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists