linux-kernel - Re: [PATCH 7/11] ksm: make KSM page migration possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Jan 2013 18:41:23 -0600
From:	Simon Jeons <simon.jeons@...il.com>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Petr Holasek <pholasek@...hat.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Izik Eidus <izik.eidus@...ellosystems.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 7/11] ksm: make KSM page migration possible

On Sun, 2013-01-27 at 15:12 -0800, Hugh Dickins wrote:
> On Sat, 26 Jan 2013, Simon Jeons wrote:
> > On Fri, 2013-01-25 at 18:03 -0800, Hugh Dickins wrote:
> > > +	while (!get_page_unless_zero(page)) {
> > > +		/*
> > > +		 * Another check for page->mapping != expected_mapping would
> > > +		 * work here too.  We have chosen the !PageSwapCache test to
> > > +		 * optimize the common case, when the page is or is about to
> > > +		 * be freed: PageSwapCache is cleared (under spin_lock_irq)
> > > +		 * in the freeze_refs section of __remove_mapping(); but Anon
> > > +		 * page->mapping reset to NULL later, in free_pages_prepare().
> > > +		 */
> > > +		if (!PageSwapCache(page))
> > > +			goto stale;
> > > +		cpu_relax();
> > > +	}
> > > +
> > > +	if (ACCESS_ONCE(page->mapping) != expected_mapping) {
> > >  		put_page(page);
> > >  		goto stale;
> > >  	}
> > > +
> > >  	if (locked) {
> > >  		lock_page(page);
> > > -		if (page->mapping != expected_mapping) {
> > > +		if (ACCESS_ONCE(page->mapping) != expected_mapping) {
> > >  			unlock_page(page);
> > >  			put_page(page);
> > >  			goto stale;
> > >  		}
> > >  	}
> > 
> > Could you explain why need check page->mapping twice after get page?
> 
> Once for the !locked case, which should not return page if mapping changed.
> Once for the locked case, which should not return page if mapping changed.
> We could use "else", but that wouldn't be an improvement.

But for locked case, page->mapping will be check twice.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/