linux-kernel - Re: [patch] TTY: synclink, small cleanup in dtr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Jan 2013 13:06:23 +0100
From:	walter harms <wharms@....de>
To:	Joe Perches <joe@...ches.com>
CC:	Dan Carpenter <dan.carpenter@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	Paul Fulghum <paulkf@...rogate.com>,
	David Howells <dhowells@...hat.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] TTY: synclink, small cleanup in dtr_rts()



Am 27.01.2013 22:00, schrieb Joe Perches:
> On Sun, 2013-01-27 at 23:19 +0300, Dan Carpenter wrote:
>> On Sun, Jan 27, 2013 at 12:04:38PM -0800, Joe Perches wrote:
>>> Wouldn't it be clearer still to use | instead of +
>> Yeah.  I think it would be, but adding bitflags together instead of
>> doing bitwise ORs is very common as well.
> 
> Fortunately, less and less so.
> 
> Another option might be to add another #define
> to include/uapi/linux/synclink.h
> 
> #define SerialSignal_DTR_RTS	(SerialSignal_DTR | SerialSignal_RTS)


Do you really want every possible combination ready as define ?
please stay with: (SerialSignal_DTR | SerialSignal_RTS)
Everyone using serial should know about DTR and RTS

re,
 wh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/