linux-kernel - Re: linux-next: manual merge of the tty tree with the input tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Jan 2013 22:38:03 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Joe Millenbach <jmillenbach@...il.com>
Cc:	Josh Triplett <josh@...htriplett.org>, Greg KH <greg@...ah.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Brian Swetland <swetland@...gle.com>,
	"Mike A. Chan" <mikechan@...gle.com>,
	Sheng Yang <sheng@...ux.intel.com>,
	Yunhong Jiang <yunhong.jiang@...el.com>,
	Xiaohui Xin <xiaohui.xin@...el.com>,
	Jun Nakajima <jun.nakajima@...el.com>,
	Bruce Beare <bruce.j.beare@...el.com>,
	Tom Keel <thomas.keel@...el.com>,
	Alan Cox <alan@...ux.intel.com>,
	Jamey Sharp <jamey@...ilop.net>
Subject: Re: linux-next: manual merge of the tty tree with the input tree

Hi Joe,

On Mon, Jan 28, 2013 at 10:26:47PM -0800, Joe Millenbach wrote:
> On Mon, Jan 28, 2013 at 9:33 PM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
> > Please revert the input changes and add *ONE* new dependency to the
> > serport driver.
> >
> > Thanks.
> >
> > --
> > Dmitry
> 
> Apologies on this.  I must have misunderstood the problem originally,
> and I definitely misunderstood your solution until I looked at it
> again.  I just went through applying the changes I'd created minus the
> driver/input changes, plus your SERPORT TTY dependency.  You were
> right that it solves the dependency issue and is much more elegant.  I
> thought it was going to leave dangling select dependencies for users
> to deal with later.  Sorry I was so hesitant at first.
> 
> I'll be making up a new patch for Greg after I get it reviewed.

Thank you for making the changes.

By the "dangling select dependencies" I assume you mean "select SERIO"
that several drivers do? "select SERIO" selects only serio core which is
self contained and has no additional dependencies [so far], that is why
it is being selected rather than being depended upon.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/