linux-kernel - Re: [PATCH] arm: fix returning wrong CALLER_ADDRx

Open Source and information security mailing list archives

Date:	Tue, 29 Jan 2013 13:01:12 +0000
From:	Dave Martin <dave.martin@...aro.org>
To:	Keun-O Park <kpark3469@...il.com>
Cc:	rostedt@...dmis.org, sahara <keun-o.park@...driver.com>,
	linux@....linux.org.uk, fweisbec@...il.com,
	linux-kernel@...r.kernel.org, mingo@...hat.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm: fix returning wrong CALLER_ADDRx

On Fri, Jan 11, 2013 at 04:18:10PM +0900, Keun-O Park wrote:
> From: sahara <keun-o.park@...driver.com>
> 
> This makes return_address return correct value for ftrace feature.
> unwind_frame does not update frame->lr but frame->pc for backtrace.
> And, the initialization for data.addr was missing so that wrong value
> returned when unwind_frame failed.
> 
> Signed-off-by: sahara <keun-o.park@...driver.com>

Reviewed-by: Dave Martin <dave.martin@...aro.org>

This is the same as a patch I previously posted:
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/129381.html

...except for the initialisation of data.addr to NULL, which is needed
in order to prevent a garbage pointer being returned in the case where
the unwinder fails to unwind a frame before the required level
is reached.

Cheers
---Dave

> ---
>  arch/arm/kernel/return_address.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c
> index 8085417..fafedd8 100644
> --- a/arch/arm/kernel/return_address.c
> +++ b/arch/arm/kernel/return_address.c
> @@ -26,7 +26,7 @@ static int save_return_addr(struct stackframe *frame, void *d)
>  	struct return_address_data *data = d;
>  
>  	if (!data->level) {
> -		data->addr = (void *)frame->lr;
> +		data->addr = (void *)frame->pc;
>  
>  		return 1;
>  	} else {
> @@ -41,7 +41,8 @@ void *return_address(unsigned int level)
>  	struct stackframe frame;
>  	register unsigned long current_sp asm ("sp");
>  
> -	data.level = level + 1;
> +	data.level = level + 2;
> +	data.addr = NULL;
>  
>  	frame.fp = (unsigned long)__builtin_frame_address(0);
>  	frame.sp = current_sp;
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives