linux-kernel - Re: [tpmdd-devel] [PATCH] TPM: Work around buggy TPMs that block during continue self test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 1 Feb 2013 16:03:26 -0700
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Kent Yoder <shpedoikal@...il.com>
Cc:	Kent Yoder <key@...ux.vnet.ibm.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Peter H?we <PeterHuewe@....de>,
	Mathias Leblanc <mathias.leblanc@...com>
Subject: Re: [tpmdd-devel] [PATCH] TPM: Work around buggy TPMs that block
 during continue self test

On Fri, Feb 01, 2013 at 04:38:42PM -0600, Kent Yoder wrote:

> >> > https://github.com/shpedoikal/linux.git tpmdd-01-22-13
> >>
> >> Thanks Kent, I will try to test your branch next week, if I am able.
> >>
> >> Can you also grab
> >>
> >> https://github.com/jgunthorpe/linux/commit/98b2a198b43b41b0535200bf475160786398f114
> >
> >  Thanks, I missed this, I'll start testing it.
> 
>   Ok, after yet another round of fixes to the stm i2c driver, I have a
> staging tree.  I'll submit this as-is next week unless something super
> ground-breaking comes up.

Great, I'll put this on my list..

I didn't receive your prior message, thank you for quoting it..

> >> https://github.com/jgunthorpe/linux/commit/9981e3e622bf702394982117134bed731ffd6f7e
> >
> >   This one is a bit out of date atm, for instance the __dev* stuff is
> > going away.  The thing that most makes me hesitant though is the config
> > if (X86 || OF).  A hardware platform or a firmware type..  What platform
> > should this actually target?

Right on the __dev stuff..

Well the 'depends on' buisness is only due to the unconditional
probing of TIS_MEM_BASE for a tpm, and then the autodetection of an
IRQ number. That procedure is very much X86 only.

My patch removes the unconditional probe when OF support is turned on,
so it is safe to use on any platform only when OF is enabled.

Yes it is really wonky, but unconditionally probing HW in a driver is
wonky these days too..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/