[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 2 Feb 2013 11:11:07 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: dirk.brandewie@...il.com
Cc: linux-kernel@...r.kernel.org, cpufreq@...r.kernel.org
Subject: Re: [PATCH 5/6] cpufreq: balance out cpufreq_cpu_{get,put} for
scaling drivers using setpolicy
On Sat, Feb 2, 2013 at 12:15 AM, <dirk.brandewie@...il.com> wrote:
> From: Dirk Brandewie <dirk.brandewie@...il.com>
>
> There is an additional reference added to the driver in
> cpufreq_add_dev_policy() that is removed in__cpufreq_governor() if the
> driver implements target(). Remove the last reference when the driver
> implements setpolicy()
>
> Signed-off-by: Dirk Brandewie <dirk.brandewie@...il.com>
Rebase it on latest work as cpufreq_add_dev_policy() doesn't exist anymore.
> ---
> drivers/cpufreq/cpufreq.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a4fd51e..ec103bf 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1119,6 +1119,9 @@ static int __cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif
> if (cpufreq_driver->target)
> __cpufreq_governor(data, CPUFREQ_GOV_STOP);
>
> + if (cpufreq_driver->setpolicy)
> + cpufreq_cpu_put(data);
> +
> kobj = &data->kobj;
> cmp = &data->kobj_unregister;
> unlock_policy_rwsem_write(cpu);
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists