linux-kernel - Re: linux-next: build failure after merge of the nfsd tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Feb 2013 07:57:19 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stanislav Kinsbursky <skinsbursky@...allels.com>
Subject: Re: linux-next: build failure after merge of the nfsd tree

On Sat, Feb 02, 2013 at 01:04:03PM +1100, Stephen Rothwell wrote:
> Hi,
> 
> After merging the nfsd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> fs/nfs/dns_resolve.c: In function 'nfs_dns_resolver_cache_init':
> fs/nfs/dns_resolve.c:375:4: error: 'struct cache_detail' has no member named 'cache_upcall'
> fs/nfs/dns_resolve.c:375:35: warning: left-hand operand of comma expression has no effect [-Wunused-value]
> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
> 
> Caused by commit aab982cb5dfb ("SUNRPC: remove cache_detail->cache_upcall
> callback").

Yes, I knew why we'd introduced cache_upcall, so I'm not sure how I
overlooked that.  It must have slipped through testing because I didn't
set CONFIG_NFS_USE_KERNEL_DNS.

We may just be able to revert that patch....  I can take care of that by
tomorrow.

> Also, why don't those statements end in semicolons?

Looks like that whole chunk was cut-and-pasted from a previous static
initializer in 1b340d0118da1d7c60c664f17d7c8fce2bb1cd9d "NFS: DNS
resolver cache per network namespace context introduced".

> 
> I have used the nsfd tree from next-20130128 for today.

Thanks.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/