linux-kernel - Re: [PATCHv2 2/2] sched/rt: add a tuning knob to allow changing SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 Feb 2013 19:57:09 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Clark Williams <williams@...hat.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 2/2] sched/rt:  add a tuning knob to allow changing
 SCHED_RR timeslice

* Ingo Molnar <mingo@...nel.org> wrote:

> The first patch looks good, I've applied it.

I've skipped this one after all, as it sometimes generates:

include/linux/sched/sysctl.h:108:41: warning: ‘struct signal_struct’ declared inside parameter list [enabled by default]

Sometimes doesn't built kernel/sched/auto_group.c. So those bits 
probably want to move into a separate sched/auto_group.h header 
or so.

But, more fundamentally, I think sched.h should not include the 
new sched/sysctl.h file. The whole point is to move out bits 
from sched.h and decouple them from sched.h - to shrink sched.h 
in the long run.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/