linux-kernel - Re: [PATCH v4 4/4] PM: Devfreq: Add Exynos5-bus devfreq driver for Exynos5250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Feb 2013 13:33:13 +0530
From:	Abhilash Kesavan <kesavan.abhilash@...il.com>
To:	"myungjoo.ham" <myungjoo.ham@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	kgene.kim@...sung.com, kyungmin.park@...sung.com, rjw@...k.pl,
	jhbird.choi@...sung.com
Subject: Re: [PATCH v4 4/4] PM: Devfreq: Add Exynos5-bus devfreq driver for Exynos5250

Hi,

> Sorry for being late.
>
> One concern is that I cannot apply Patch 1/4 directly as the .dts file isn't
> available to me.
> Do you intend to apply that patch to another tree and apply the other three
> to devfreq tree?
I have been merging the devfreq tree into Kgene's tree for my testing. I am not
sure how this should get in, any suggestions ?
>
> Another is the location of exynos_ppmu.h.
> Who is going to refer exynos_ppmu.h?
> If Exynos devfreq drivers are the only files to refer, wouldn't it be better
> located at drivers/devfreq/exynos/ ?
>
> Or do you intend to let someone else (drivers located not in
> drivers/devfreq) access exynos-ppmu?
> (If so, who's going to be? and that means we are going to have
> include/linux/devfreq/, I don't think it'd be appropriate to populate
> include/linux with device driver specific headers)
In an earlier comment on this patch Olof suggested I place it in
include/linux/. It is going to be
used only by Exynos and I will move it into drivers/devfreq/exynos as
per your suggestion.
>
>
>
> And, there are errors (we do not have __devinit/__devexit anymore):
>
>   CC      drivers/devfreq/exynos/exynos5_bus.o
> drivers/devfreq/exynos/exynos5_bus.c:315:18: error: expected =, ,, ;, asm or
> __attribute__ before int
> drivers/devfreq/exynos/exynos5_bus.c:430:18: error: expected =, ,, ;, asm or
> __attribute__ before int
> drivers/devfreq/exynos/exynos5_bus.c:462:11: error:
> exynos5_busfreq_int_probe undeclared here (not in a function)
> drivers/devfreq/exynos/exynos5_bus.c:463:2: error: implicit declaration of
> function __devexit_p [-Werror=implicit-function-declaration]
> drivers/devfreq/exynos/exynos5_bus.c:463:24: error:
> exynos5_busfreq_int_remove undeclared here (not in a function)
> drivers/devfreq/exynos/exynos5_bus.c:235:35: warning:
> exynos5_devfreq_int_profile defined but not used [-Wunused-variable]
> drivers/devfreq/exynos/exynos5_bus.c:243:12: warning:
> exynos5250_init_int_tables defined but not used [-Wunused-function]
> drivers/devfreq/exynos/exynos5_bus.c:259:12: warning:
> exynos5_busfreq_int_pm_notifier_event defined but not used
> [-Wunused-function]
> cc1: some warnings being treated as errors
I will fix these and re-post.
>
>
>
> Cheers,
> MyungJoo.
>
Abhilash
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/