linux-kernel - Re: [PATCHv2 2/2] sched/rt: add a tuning knob to allow changing SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 Feb 2013 12:01:01 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Clark Williams <williams@...hat.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 2/2] sched/rt:  add a tuning knob to allow changing
 SCHED_RR timeslice


* Clark Williams <williams@...hat.com> wrote:

> On Sun, 3 Feb 2013 19:57:09 +0100
> Ingo Molnar <mingo@...nel.org> wrote:
> 
> > 
> > * Ingo Molnar <mingo@...nel.org> wrote:
> > 
> > > The first patch looks good, I've applied it.
> > 
> > I've skipped this one after all, as it sometimes generates:
> > 
> > include/linux/sched/sysctl.h:108:41: warning: ???struct signal_struct??? declared inside parameter list [enabled by default]
> > 
> > Sometimes doesn't built kernel/sched/auto_group.c. So those bits 
> > probably want to move into a separate sched/auto_group.h header 
> > or so.
> > 
> > But, more fundamentally, I think sched.h should not include the 
> > new sched/sysctl.h file. The whole point is to move out bits 
> > from sched.h and decouple them from sched.h - to shrink sched.h 
> > in the long run.
> > 
> > Thanks,
> > 
> > 	Ingo
> 
> Ahh, you wanted to not only reduce the size of sched.h you 
> want to reduce the amount of code it brings in.

Yeah - I wanted your series to kick-start the ambitious project 
of splitting up the mega-monolithic sched.h include file - 
without anyone noticing. Now my plan is busted.

Many good people scared away from this daunting project in the 
past one or two decades, but they were chicken!

> I'll go back to the drawing board. I'll pull the relevant code 
> from sysctl.h into auto_group.h, then I'll remove the include 
> in sched.h. Then I'll track down all the build failures from 
> the above :).

As long as a few common config combinations work fine I can help 
out with tracking down weird config failures and can also fix 
them - in fact I almost managed to fix your previous series when 
I noticed that include/sched/ is still included in sched.h. (the 
price I paid for not looking closely enough before applying the 
patches.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/