linux-kernel - Re: [PATCH 1/2] USB: storage: Define a new macro for USB storage match rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Feb 2013 10:39:29 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	fangxiaozhi 00110321 <fangxiaozhi@...wei.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	zihan@...wei.com, Lin.Lei@...wei.com, neil.yi@...wei.com,
	wangyuhua@...wei.com, huqiao36@...wei.com, balbi@...com,
	mdharm-usb@...-eyed-alien.net, sebastian@...akpoint.cc
Subject: Re: [PATCH 1/2] USB: storage: Define a new macro for USB storage
 match rules

On Mon, Feb 04, 2013 at 03:14:46PM +0800, fangxiaozhi 00110321 wrote:
> +/* Define the device is matched with Vendor ID and interface descriptors */
> +#define UNUSUAL_VENDOR_INTF(id_vendor, cl, sc, pr, \
> +			vendorName, productName, useProtocol, useTransport, \
> +			initFunction, flags) \
> +{ \
> +	.match_flags = USB_DEVICE_ID_MATCH_INT_INFO \
> +				| USB_DEVICE_ID_MATCH_VENDOR, \
> +	.idVendor    = (id_vendor), \
> +	.bInterfaceClass = (cl), \
> +	.bInterfaceSubClass = (sc), \
> +	.bInterfaceProtocol = (pr), \
> +	.driver_info = (flags) \
> +}

I'm not going to reject this given the number of times it has been
submitted, but can't you use the USB_VENDOR_AND_INTERFACE_INFO() macro
here in this definition?

If so, can you send me an add-on patch that makes that change?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/