linux-kernel - Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Feb 2013 10:51:49 +0800
From:	Roger Tseng <rogerable@...ltek.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	"cjb@...top.org" <cjb@...top.org>
CC:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Wei_wang <wei_wang@...lsil.com.cn>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
Subject: Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment

Hi Dan,

Correct. I will prevent this kind of breaking in the future.

However, after our analysis the breaking of patch 1/3 and 2/3 should not 
fail old devices. And since Samuel has applied 2/3 and 3/3, it might be 
better for Chris to apply patch 1/3 and let all this things appear in 
kernel v3.9.

Hi Chris,

Would you please apply patch 1/3 for kernel v3.9. Thanks.

Best regards,
Roger Tseng

On 02/04/2013 04:47 PM, Dan Carpenter wrote:
> On Mon, Feb 04, 2013 at 03:45:57PM +0800, Roger Tseng wrote:
>> Several new models of readers use different way to select driving
>> capability(a necessary adjustment along with voltage change). Removing this
>> from device-independent rtsx_pci_sdmmc module. It will be implemented in
>> device-depend calls encapsulated by rtsx_pci_switch_output_voltage().
>>
>
> I'm not sure I understand.
>
> Does this patch break things and then "[PATCH 2/3] mfd: rtsx:
> implement driving adjustment to device-dependent callbacks" fixes
> things again?  In other words, will all the old devices run if we
> only apply patch 1/3 and not 2/3?
>
> That's not the right idea.  Just merge the two patches into one
> patch.
>
> regards,
> dan carpenter
>
>
> ------Please consider the environment before printing this e-mail.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/