linux-kernel - [PATCH] staging/vt6656: Fix sparse warning constant 0xffffffff00000000U is so big it is unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue,  5 Feb 2013 23:31:37 +0100
From:	Peter Huewe <peterhuewe@....de>
To:	Forest Bond <forest@...ttletooquiet.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Malcolm Priestley <tvboxspy@...il.com>,
	"Justin P. Mattock" <justinmattock@...il.com>,
	Peter Huewe <peterhuewe@....de>,
	Marcos Paulo de Souza <marcos.souza.org@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	kbuild@...org
Subject: [PATCH] staging/vt6656: Fix sparse warning constant 0xffffffff00000000U is so big it is unsigned long

Since 7c65fa2a4c176c9bfab1ef954c4cef005dd9fb8b
'staging: vt6656: Remove QWORD from source and replace with u64.'
a new sparse warning showed up:

'drivers/staging/vt6656/card.c:798:26: sparse: constant
 0xffffffff00000000U is so big it is unsigned long'

-> Append L to fix the warning.

Reported-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Peter Huewe <peterhuewe@....de>
---
 drivers/staging/vt6656/card.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index 7d725bb..f988f07 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -790,7 +790,7 @@ u64 CARDqGetNextTBTT(u64 qwTSF, WORD wBeaconInterval)
 	if ((~uLowNextTBTT) < uLowRemain)
 		qwTSF = ((qwTSF >> 32) + 1) << 32;
 
-	qwTSF = (qwTSF & 0xffffffff00000000U) |
+	qwTSF = (qwTSF & 0xffffffff00000000UL) |
 		(u64)(uLowNextTBTT + uLowRemain);
 
     return (qwTSF);
-- 
1.7.8.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/