linux-kernel - Re: [PATCH] asm-generic: io: Fix ioread16/32be and iowrite16/32be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Feb 2013 07:48:01 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	linux-kernel@...r.kernel.org, monstr@...str.eu,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Arnd Bergmann <arnd@...db.de>,
	Will Deacon <will.deacon@....com>, linux-arch@...r.kernel.org
Subject: Re: [PATCH] asm-generic: io: Fix ioread16/32be and iowrite16/32be

On Thu, Feb 7, 2013 at 3:18 PM, Michal Simek <michal.simek@...inx.com> wrote:
> Fix ioreadXXbe and iowriteXXbe functions which did
> additional little endian conversion on native big endian systems.
> Using be_to_cpu (cpu_to_be) conversions with __raw_read/write
> functions have resolved it.
>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> CC: Arnd Bergmann <arnd@...db.de>
> CC: Geert Uytterhoeven <geert@...ux-m68k.org>
> CC: Will Deacon <will.deacon@....com>
> CC: linux-arch@...r.kernel.org

I have one question (see below). Apart from that:
Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> -#define ioread16be(addr)       be16_to_cpu(ioread16(addr))
> +#define ioread16be(addr)       __be16_to_cpu(__raw_readw(addr))

Why did you change it to the __beX_to_cpu variant with underscores?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/