linux-kernel - Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Feb 2013 12:53:13 -0500
From:	Chris Ball <cjb@...top.org>
To:	Roger Tseng <rogerable@...ltek.com>
Cc:	<sameo@...ux.intel.com>, <devel@...uxdriverproject.org>,
	<linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <wei_wang@...lsil.com.cn>
Subject: Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment

Hi,

On Mon, Feb 04 2013, Roger Tseng wrote:
> Several new models of readers use different way to select driving
> capability(a necessary adjustment along with voltage change). Removing this
> from device-independent rtsx_pci_sdmmc module. It will be implemented in
> device-depend calls encapsulated by rtsx_pci_switch_output_voltage().
>
> Signed-off-by: Roger Tseng <rogerable@...ltek.com>
> Reviewed-by: Wei WANG <wei_wang@...lsil.com.cn>
> ---
>  drivers/mmc/host/rtsx_pci_sdmmc.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
> index f74b5ad..f93f100 100644
> --- a/drivers/mmc/host/rtsx_pci_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
> @@ -1083,11 +1083,6 @@ static int sdmmc_switch_voltage(struct mmc_host *mmc, struct mmc_ios *ios)
>  		voltage = OUTPUT_1V8;
>  
>  	if (voltage == OUTPUT_1V8) {
> -		err = rtsx_pci_write_register(pcr,
> -				SD30_DRIVE_SEL, 0x07, DRIVER_TYPE_B);
> -		if (err < 0)
> -			goto out;
> -
>  		err = sd_wait_voltage_stable_1(host);
>  		if (err < 0)
>  			goto out;

Thanks, I've pushed 1/3 to mmc-next for 3.9 now.

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/