linux-kernel - Re: [PATCH V4 1/2] get_maintainer: allow keywords to match filenames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Feb 2013 22:17:55 -0800
From:	Joe Perches <joe@...ches.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	arm@...nel.org, linux-tegra@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Julian Andres Klode <jak@...-linux.org>,
	Marc Dietrich <marvin24@....de>,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH V4 1/2] get_maintainer: allow keywords to match filenames

On Mon, 2013-02-11 at 17:39 -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@...dia.com>
> 
> Allow K: entries in MAINTAINERS to match directly against filenames;
> either those extracted from patch +++ or --- lines, or those specified
> on the command-line using the -f option.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -97,12 +97,12 @@ Descriptions of section entries:
>  	   X:	net/ipv6/
>  	   matches all files in and below net excluding net/ipv6/
>  	K: Keyword perl extended regex pattern to match content in a
> -	   patch or file.  For instance:
> +	   patch, or an affected filename.  For instance:

The removal of file isn't correct.

This should read "patch, file or filename".

If the -f pattern is a single file,
get_maintainer reads that file content and then
matches any K: patterns.

When the -f pattern is a directory, it doesn't.

>  	   K: of_get_profile
> -	      matches patches or files that contain "of_get_profile"
> +	      matches patches or filenames that contain "of_get_profile"

here too.

>  	   K: \b(printk|pr_(info|err))\b
> -	      matches patches or files that contain one or more of the words
> -	      printk, pr_info or pr_err
> +	      matches patches or filenames that contain one or more of
> +	      the words printk, pr_info or pr_err

three.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/