linux-kernel - Re: [PATCH] drm: make frame duration time calculation more precise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Feb 2013 06:29:51 -0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	David Airlie <airlied@...ux.ie>
Cc:	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	marcheu@...omium.org, Daniel Kurtz <djkurtz@...omium.org>
Subject: Re: [PATCH] drm: make frame duration time calculation more precise

On Wed, Dec 26, 2012 at 5:01 PM, Daniel Kurtz <djkurtz@...omium.org> wrote:
>
> It is a bit more precise to compute the total number of pixels first and
> then divide, rather than multiplying the line pixel count by the
> already-rounded line duration.
>
> Signed-off-by: Daniel Kurtz <djkurtz@...omium.org>

Ping?

> ---
>  drivers/gpu/drm/drm_irq.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> index 19c01ca..05c91e0 100644
> --- a/drivers/gpu/drm/drm_irq.c
> +++ b/drivers/gpu/drm/drm_irq.c
> @@ -505,6 +505,7 @@ void drm_calc_timestamping_constants(struct drm_crtc
> *crtc)
>
>         /* Valid dotclock? */
>         if (dotclock > 0) {
> +               int frame_size;
>                 /* Convert scanline length in pixels and video dot clock
> to
>                  * line duration, frame duration and pixel duration in
>                  * nanoseconds:
> @@ -512,7 +513,10 @@ void drm_calc_timestamping_constants(struct drm_crtc
> *crtc)
>                 pixeldur_ns = (s64) div64_u64(1000000000, dotclock);
>                 linedur_ns  = (s64) div64_u64(((u64)
> crtc->hwmode.crtc_htotal *
>                                               1000000000), dotclock);
> -               framedur_ns = (s64) crtc->hwmode.crtc_vtotal * linedur_ns;
> +               frame_size = crtc->hwmode.crtc_htotal *
> +                               crtc->hwmode.crtc_vtotal;
> +               framedur_ns = (s64) div64_u64((u64) frame_size *
> 1000000000,
> +                                             dotclock);
>         } else
>                 DRM_ERROR("crtc %d: Can't calculate constants, dotclock =
> 0!\n",
>                           crtc->base.id);
> --
> 1.7.7.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/