| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Feb 2013 10:41:22 -0800 From: Doug Anderson <dianders@...omium.org> To: Wolfram Sang <wsa@...-dreams.de> Cc: Stephen Warren <swarren@...dotorg.org>, Doug Anderson <dianders@...omium.org>, Peter Korsgaard <peter.korsgaard@...co.com>, "Ben Dooks (embedded platforms)" <ben-linux@...ff.org>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove Stephen Warren pointed out as part of a code review of another mux driver that there should be no need to have "platform_set_drvdata(pdev, NULL)" in the remove function. Get rid of it in the i2c-mux-gpio driver. See Stephen's comment at: http://www.gossamer-threads.com/lists/linux/kernel/1678627?do=post_view_threaded#1678627 Signed-off-by: Doug Anderson <dianders@...omium.org> --- drivers/i2c/muxes/i2c-mux-gpio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c index 9f50ef0..abc2e55a 100644 --- a/drivers/i2c/muxes/i2c-mux-gpio.c +++ b/drivers/i2c/muxes/i2c-mux-gpio.c @@ -250,7 +250,6 @@ static int i2c_mux_gpio_remove(struct platform_device *pdev) for (i = 0; i < mux->data.n_gpios; i++) gpio_free(mux->gpio_base + mux->data.gpios[i]); - platform_set_drvdata(pdev, NULL); i2c_put_adapter(mux->parent); return 0; -- 1.8.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists