linux-kernel - Re: [RFC/RFT][PATCH 1/3] regulator: core: Add enable_pulldown flag to indicate pulldown on EN input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 16 Feb 2013 13:57:29 +0800
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"Jett.Zhou" <jtzhou@...vell.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC/RFT][PATCH 1/3] regulator: core: Add enable_pulldown flag to
 indicate pulldown on EN input

On Sat, Feb 16, 2013 at 1:35 PM, Axel Lin <axel.lin@...ics.com> wrote:
>
>> I think that enable_pulldown is a little hard to understand. How about
>> change
>> the name, like set_to_disable or something else?
>
>
> How about "enable_invert"?
> ( We have ena_gpio_invert setting for GPIO controlled enable lines )
>
> Then I'll update the comments to:
> @enable_invert: A flag to indicate set enable_mask bits to disable when
> using
>                 regulator_enable_regmap and friends APIs.
>
> Axel

enable_is_inverted is better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/