linux-kernel - Re: fb: mmp: include linux/platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Feb 2013 23:45:33 +0800
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Zhou Zhu <zzhu3@...vell.com>, Lisa Du <cldu@...vell.com>,
	Guoqing Li <ligq@...vell.com>
Subject: Re: fb: mmp: include linux/platform_device.h

On Fri, Feb 15, 2013 at 10:16 PM, Arnd Bergmann <arnd@...db.de> wrote:
> Patch 16559ae "kgdb: remove #include <linux/serial_8250.h> from kgdb.h"
> changes the kgdb.h file so that drivers including it do not implicitly
> include linux/platform_device.h. The mmp framebuffer driver is new,
> so Greg did not have a chance to fix it up when introducing his change.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> On Thursday 14 February 2013, Greg Kroah-Hartman wrote:
>> On Thu, Feb 14, 2013 at 11:26:56PM +0100, Arnd Bergmann wrote:
>> > Patch 16559ae "kgdb: remove #include <linux/serial_8250.h> from kgdb.h"
>> > removed an implicit inclusion of linux/platform_device.h
>> > In a number of places. This adds back explicit inclusions in a few
>> > more places I found.
>>
>> >  drivers/video/mmp/fb/mmpfb.c             | 1 +
>>
>> This file isn't my tty tree, so I can't apply that part of the patch,
>> but I've applied the rest of the patch, and the 2 others you sent me to
>> fix this issue.
>
> Right. It seems the driver is only in Andrew's tree. Andrew, can you
> add this hunk on top?
>
> diff --git a/drivers/video/mmp/fb/mmpfb.c b/drivers/video/mmp/fb/mmpfb.c
> index f34a3a9..6d1fa96 100644
> --- a/drivers/video/mmp/fb/mmpfb.c
> +++ b/drivers/video/mmp/fb/mmpfb.c
> @@ -21,6 +21,7 @@
>   */
>  #include <linux/module.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/platform_device.h>
>  #include "mmpfb.h"
>
>  static int var_to_pixfmt(struct fb_var_screeninfo *var)

Acked-by: Haojian Zhuang <haojian.zhuang@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/