linux-kernel - Re: [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2013 10:48:55 +0900
From:	gshark <gshark.jeong@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Andrew Morton' <akpm@...ux-foundation.org>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Richard Purdie' <rpurdie@...ys.net>,
	'Daniel Jeong' <daniel.jeong@...il.com>
Subject: Re: [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight_register()

2013년 02월 04일 09:14, Jingoo Han 쓴 글:
> There is no need to return -EIO, because backlight_device_register()
> already returns correct error values.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>   drivers/video/backlight/lm3630_bl.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/lm3630_bl.c b/drivers/video/backlight/lm3630_bl.c
> index a6d637b..76a62e9 100644
> --- a/drivers/video/backlight/lm3630_bl.c
> +++ b/drivers/video/backlight/lm3630_bl.c
> @@ -320,7 +320,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,
>   		    backlight_device_register(name, pchip->dev, pchip,
>   					      &lm3630_bank_a_ops, &props);
>   		if (IS_ERR(pchip->bled1))
> -			return -EIO;
> +			return PTR_ERR(pchip->bled1);
>   		break;
>   	case BLED_2:
>   		props.brightness = pdata->init_brt_led2;
> @@ -329,7 +329,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,
>   		    backlight_device_register(name, pchip->dev, pchip,
>   					      &lm3630_bank_b_ops, &props);
>   		if (IS_ERR(pchip->bled2))
> -			return -EIO;
> +			return PTR_ERR(pchip->bled2);
>   		break;
>   	}
>   	return 0;

Thank you. This patch looks good for us.
Acked-by: Daniel Jeong<daniel.jeong@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/