linux-kernel - Re: [PATCH v4 0/7] Driver for Si476x series of chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2013 21:05:19 -0800
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Andrey Smirnov <andrew.smirnov@...il.com>
Cc:	broonie@...nsource.wolfsonmicro.com, mchehab@...hat.com,
	sameo@...ux.intel.com, perex@...ex.cz, tiwai@...e.de,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/7] Driver for Si476x series of chips

On Monday, February 18, 2013 19:59:28 Andrey Smirnov wrote:
> This is a fourth version of the patchset originaly posted here:
> https://lkml.org/lkml/2012/9/13/590
> 
> Second version of the patch was posted here:
> https://lkml.org/lkml/2012/10/5/598
> 
> Third version of the patch was posted here:
> https://lkml.org/lkml/2012/10/23/510
> 
> To save everyone's time I'll repost the original description of it:
> 
> This patchset contains a driver for a Silicon Laboratories 476x series
> of radio tuners. The driver itself is implemented as an MFD devices
> comprised of three parts: 
>  1. Core device that provides all the other devices with basic
> functionality and locking scheme.
>  2. Radio device that translates between V4L2 subsystem requests into
> Core device commands.
>  3. Codec device that does similar to the earlier described task, but
> for ALSA SoC subsystem.
> 
> v4 of this driver has following changes:
>  - All of the adjustable timeouts(expose via sysfs) are gone
>  - Names of the controls are changes as was requested
>  - Added documentation for exposed debugfs files 
>  - Minor fix in si476x_radio_fops_poll
>  - DBG_BUFFER is removed
>  - Tested for compilation w/o debugfs enabled
> 
> This version still has all the radio controls being private. The
> reason for that is because I am not sure how that should be handled.
> 
> Hans, do you want me to move all the controls to be standard, that is
> exted V4L's with the needed controls? Should I pick up the parts of
> http://lists-archives.com/linux-kernel/27641304-radio-fixes-and-new-features-for-fm.html and take relevants bits and pieces of it?

Yes, please do that. It's too bad that never made it into the kernel, so let's
do it now.

So take the controls that you can use from that patch and leave out those that
do not apply to your driver. From the remaining controls not covered by that
patch you will have to decide which are truly chip-specific and which are
valid for any advanced radio receiver.

The really chip(set) specific controls should be put in their own header,
but add the base control ID to v4l2-controls.h (see for example the way that
is done for the MEYE controls).

If you can do that quickly and post a v5, then I will do my best to review
it this week or Monday at the latest. Let's finish this driver asap.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/