linux-kernel - Re: [PATCH, RFC 6/8] ARM: OMAP2+: am43: basic dt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2013 16:02:39 +0530
From:	Santosh Shilimkar <santosh.shilimkar@...com>
To:	Afzal Mohammed <afzal@...com>
CC:	<linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<devicetree-discuss@...ts.ozlabs.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>,
	Marc Zyngier <marc.zyngier@....com>,
	Nicolas Pitre <nico@...aro.org>,
	Will Deacon <will.deacon@....com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Landley <rob@...dley.net>, Sekhar Nori <nsekhar@...com>,
	Syed Mohammed Khasim <khasim@...com>
Subject: Re: [PATCH, RFC 6/8] ARM: OMAP2+: am43: basic dt support

On Monday 18 February 2013 05:08 PM, Afzal Mohammed wrote:
> Describe minimal DT boot machine details for AM43 based SoC's. AM43
> family of SoC's are ARM Cortex-A9 based with one core in SMP
> configuration. Low level debug could be achieved by selecting
> DEBUG_AM33XXUART1. To boot AM43 SoC, this change is sufficient w.r.t
> Kernel (considering the fact that strictly speaking DT sources does
> not classify as a part of Kernel). Here private timer of the one and
> only core is being used as clock event (as well as, as time source).
>
> Signed-off-by: Afzal Mohammed <afzal@...com>
> ---
As discussed already, lets just call this as Cortex-A9 single core
machine to avoid confusion.

>   arch/arm/mach-omap2/board-generic.c | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index 0274ff7..e083f08 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -15,7 +15,10 @@
>   #include <linux/of_irq.h>
>   #include <linux/of_platform.h>
>   #include <linux/irqdomain.h>
> +#include <linux/irqchip.h>
>
> +#include <asm/mach/map.h>
> +#include <asm/smp_twd.h>
>   #include <asm/mach/arch.h>
>
>   #include "common.h"
> @@ -182,3 +185,18 @@ DT_MACHINE_START(OMAP5_DT, "Generic OMAP5 (Flattened Device Tree)")
>   	.restart	= omap44xx_restart,
>   MACHINE_END
>   #endif
> +
> +#ifdef CONFIG_SOC_AM43
> +static const char *am43_boards_compat[] __initdata = {
> +	"ti,am43",
> +	NULL,
> +};
> +
> +DT_MACHINE_START(AM43_DT, "Generic AM43 (Flattened Device Tree)")
> +	.map_io		= debug_ll_io_init,
> +	.init_irq	= irqchip_init,
With Arnds patch [1], the above can be dropped..

> +	.init_machine	= omap_generic_init,
> +	.init_time	= twd_local_timer_of_register,
This one needs to take care of other timers as well from start. So
better to take that approach from start.

Regards,
Santosh

[1] https://patchwork.kernel.org/patch/2074871/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/