linux-kernel - Re: [patch v5 11/15] sched: add power/performance balance allow flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Feb 2013 22:20:19 +0800
From:	Alex Shi <alex.shi@...el.com>
To:	Borislav Petkov <bp@...en8.de>, torvalds@...ux-foundation.org,
	mingo@...hat.com, peterz@...radead.org, tglx@...utronix.de,
	akpm@...ux-foundation.org, arjan@...ux.intel.com, pjt@...gle.com,
	namhyung@...nel.org, efault@....de, vincent.guittot@...aro.org,
	gregkh@...uxfoundation.org, preeti@...ux.vnet.ibm.com,
	viresh.kumar@...aro.org, linux-kernel@...r.kernel.org,
	morten.rasmussen@....com
Subject: Re: [patch v5 11/15] sched: add power/performance balance allow flag


>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 2e8131d..0047856 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -4053,6 +4053,8 @@ struct lb_env {
>>  	unsigned int		loop;
>>  	unsigned int		loop_break;
>>  	unsigned int		loop_max;
>> +	int			power_lb;  /* if power balance needed */
>> +	int			perf_lb;   /* if performance balance needed */
> 
> Those look like they're used like simple boolean flags. Why not make
> them such, i.e. bitfields? See struct perf_event_attr for an example.

there are 11 long words in struct lb_env now. use boolean or bitfields
can't save much space. and not use conveniently.
> 
> Thanks.
> 


-- 
Thanks
    Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/