linux-kernel - Re: [PATCH] HID: make sensor autodetection independent of underlying bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Feb 2013 11:42:59 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Alexander Holler <holler@...oftware.de>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	srinivas.pandruvada@...el.com
Subject: Re: [PATCH] HID: make sensor autodetection independent of underlying bus

On Tue, Feb 19, 2013 at 10:22 AM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> Instead of limiting HID sensors to USB and I2C busses we can just make
> everything that has usage page of HID_UP_SENSOR to be included in
> HID_GROUP_SENSOR_HUB group. This allows the sensor-hub to work over
> bluetooth (and other transports) as well.
>
> Reported-by: Alexander Holler <holler@...oftware.de>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Reviewed-By: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin

> ---
>  drivers/hid/hid-core.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index fe3a59e..f89e902 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -728,8 +728,7 @@ static int hid_scan_report(struct hid_device *hid)
>                 } else if (page == HID_UP_SENSOR &&
>                         item.type == HID_ITEM_TYPE_MAIN &&
>                         item.tag == HID_MAIN_ITEM_TAG_BEGIN_COLLECTION &&
> -                       (item_udata(&item) & 0xff) == HID_COLLECTION_PHYSICAL &&
> -                       (hid->bus == BUS_USB || hid->bus == BUS_I2C))
> +                       (item_udata(&item) & 0xff) == HID_COLLECTION_PHYSICAL)
>                         hid->group = HID_GROUP_SENSOR_HUB;
>         }
>
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/