linux-kernel - Re: [PATCH] microblaze idle: Fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Feb 2013 17:25:17 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Len Brown <lenb@...nel.org>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, microblaze-uclinux@...e.uq.edu.au
Subject: Re: [PATCH] microblaze idle: Fix compile error

On Thursday, February 21, 2013 11:15:31 AM Lars-Peter Clausen wrote:
> Commit def8203 ("microblaze idle: delete pm_idle") introduced the following
> compile error:
> 
> 	arch/microblaze/kernel/process.c: In function 'cpu_idle':
> 	arch/microblaze/kernel/process.c:100: error: 'idle' undeclared (first use in this function)
> 	arch/microblaze/kernel/process.c:100: error: (Each undeclared identifier is reported only once
> 	arch/microblaze/kernel/process.c:100: error: for each function it appears in.)
> 	arch/microblaze/kernel/process.c:106: error: implicit declaration of function 'idle'
> 
> This patch fixes it.
> 
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>

Applied to linux-pm.git/linux-next, I'm going to push it to Linus later this
week.

Thanks,
Rafael


> ---
>  arch/microblaze/kernel/process.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/microblaze/kernel/process.c b/arch/microblaze/kernel/process.c
> index 6ff2dcf..08f8734 100644
> --- a/arch/microblaze/kernel/process.c
> +++ b/arch/microblaze/kernel/process.c
> @@ -97,13 +97,10 @@ void cpu_idle(void)
>  
>  	/* endless idle loop with no priority at all */
>  	while (1) {
> -		if (!idle)
> -			idle = default_idle;
> -
>  		tick_nohz_idle_enter();
>  		rcu_idle_enter();
>  		while (!need_resched())
> -			idle();
> +			default_idle();
>  		rcu_idle_exit();
>  		tick_nohz_idle_exit();
>  
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/